Add #[precompile::view] attribute to getTotalColdkeyStake and getTotalHotkeyStake#1380
Closed
Shr1ftyy wants to merge 2 commits intoopentensor:devnet-readyfrom
Closed
Add #[precompile::view] attribute to getTotalColdkeyStake and getTotalHotkeyStake#1380Shr1ftyy wants to merge 2 commits intoopentensor:devnet-readyfrom
#[precompile::view] attribute to getTotalColdkeyStake and getTotalHotkeyStake#1380Shr1ftyy wants to merge 2 commits intoopentensor:devnet-readyfrom
Conversation
- added view attribute to getTotalColdkeyStake and getTotalHotkeyStake functions
Closed
13 tasks
ales-otf
approved these changes
Mar 10, 2025
ales-otf
requested changes
Mar 10, 2025
Contributor
ales-otf
left a comment
There was a problem hiding this comment.
Please, make this change for both precompile versions.
This was referenced Mar 11, 2025
Contributor
|
merged via this. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These functions in the staking precompile (which I added, and also got recently merged in 😭) cannot be called from within static contexts (i.e.
viewandpure) functions, even though they do not actually modify state. This PR addresses this issue.Related Issue(s)
getTotalColdkeyStakeandgetTotalHotkeyStakecan't be called from within static contexts #1345Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctly